fix: /ok-to-test /retest pipelineruns should not be created if last sha successful #2048
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
waveywaves
force-pushed
the
execute-non-successful
branch
9 times, most recently
from
fa2a595 to
72e4aca
Compare
|
/cancel |
waveywaves
force-pushed
the
execute-non-successful
branch
2 times, most recently
from
579fd77 to
7508871
Compare
waveywaves
changed the title
There was a problem hiding this comment.
Copilot reviewed 1 out of 1 changed files in this pull request and generated no comments.
Comments suppressed due to low confidence (1)
pkg/pipelineascode/pipelineascode.go:196
- [nitpick] Consider renaming the variable 'existingPRs' (later in the block) to 'existingRuns' or similar to more clearly indicate that it represents a collection of PipelineRun objects.
labelSelector := fmt.Sprintf("%s=%s", keys.SHA, formatting.CleanValueKubernetes(p.event.SHA))
|
/retest |
waveywaves
force-pushed
the
execute-non-successful
branch
5 times, most recently
from
8f5c0ab to
b44e208
Compare
|
cc @chmouel seems like the provider e2e tests are not running :/ wanted to test them, not sure what's up |
|
cc @zakisk |
zakisk
reviewed
Apr 21, 2025
waveywaves
force-pushed
the
execute-non-successful
branch
25 times, most recently
from
60e1716 to
3554d83
Compare
…ipelineruns when executing /ok-to-test or /retest gitops commands, check whether the last pipelinerun created for the same SHA was successful. If the run was successful, skip new pipelinerun creation - Add checkForExistingSuccessfulPipelineRun logic to prevent creating duplicate PipelineRuns when /retest or /ok-to-test commands are used and a successful PipelineRun already exists for the same SHA - Fix cancel-in-progress flow by short-circuiting PullRequestClosed events to avoid interference with matching logic - Ensure /retest <pipelinerun-name> commands always create new PipelineRuns as explicitly requested by users - Add GetOriginalPipelineRunName helper function to eliminate duplicate logic across test files for finding PipelineRun names - Fix multiple tests that incorrectly used plain /retest expecting multiple PipelineRuns: now use /retest <name> for forced reruns - Update max-keep-runs tests to use specific PipelineRun names for proper testing of cleanup functionality - Fix timing issues in tests by adding proper waits for Repository CRD updates
waveywaves
force-pushed
the
execute-non-successful
branch
from
3554d83 to
7a65309
Compare
waveywaves
force-pushed
the
execute-non-successful
branch
from
fe82231 to
95d7ede
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Add checkForExistingSuccessfulPipelineRun logic to prevent creating duplicate
PipelineRuns when /retest or /ok-to-test commands are used and a
successful PipelineRun already exists for the same SHA
Fix cancel-in-progress flow by short-circuiting PullRequestClosed events
to avoid interference with matching logic
Ensure /retest commands always create new PipelineRuns
as explicitly requested by users
Add GetOriginalPipelineRunName helper function to eliminate duplicate
logic across test files for finding PipelineRun names
Fix multiple tests that incorrectly used plain /retest expecting multiple
PipelineRuns: now use /retest for forced reruns
Update max-keep-runs tests to use specific PipelineRun names for proper
testing of cleanup functionality
Fix timing issues in tests by adding proper waits for Repository CRD updates
fixes #1959
Submitter Checklist
📝 Ensure your commit message is clear and informative. Refer to the How to write a git commit message guide. Include the commit message in the PR body rather than linking to an external site (e.g., Jira ticket).
♽ Run make test lint before submitting a PR to avoid unnecessary CI processing. Consider installing pre-commit and running pre-commit install in the repository root for an efficient workflow.
✨ We use linters to maintain clean and consistent code. Run make lint before submitting a PR. Some linters offer a --fix mode, executable with make fix-linters (ensure markdownlint and golangci-lint are installed).
📖 Document any user-facing features or changes in behavior.
🧪 While 100% coverage isn't required, we encourage unit tests for code changes where possible.
🎁 If feasible, add an end-to-end test. See README for details.
🔎 Address any CI test flakiness before merging, or provide a valid reason to bypass it (e.g., token rate limitations).
If adding a provider feature, fill in the following details:
(update the provider documentation accordingly)